Allow unicode cdot to be considered operator alongside * #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice idea! I think it would be better for maintainability to add Could you write some tests? Especially try to catch the "is not affected by cdot=false" behavior, and that it's parenthesized correctly. |
|
That's a good suggestion. I'll try to write some tests as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you want to assign unicode cdot to dot product, etc but latexify will render it like a function. This PR should allow the unicode cdot to be rendered like the asterisk. It is also immune to kwargs cdot = false because sometimes you want to notate the dot in certain circumstance, etc